Skip to content

feat: add bond beneficiaries #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Axel-IoBuilders merged 30 commits into from
Sep 16, 2025
Merged

feat: add bond beneficiaries #660

Axel-IoBuilders merged 30 commits into from
Sep 16, 2025

Conversation

@Axel-IoBuilders
Copy link
Contributor

@Axel-IoBuilders Axel-IoBuilders commented Sep 16, 2025

Description

Create SC Beneficiaries
Add beneficiaries methods in SDK
Implementation in WEB

image image

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage ✅

@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Sep 16, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@AlbertoMolinaIoBuilders @Axel-IoBuilders
feature: beneficiaries facet added
4867c2d 
Signed-off-by: Alberto Molina <[email protected]>
@AlbertoMolinaIoBuilders @Axel-IoBuilders
beneficiaries using external lists
4124929 
Signed-off-by: Alberto Molina <[email protected]>
@AlbertoMolinaIoBuilders @Axel-IoBuilders
factory updated with beneficiaries
a8b2911 
Signed-off-by: Alberto Molina <[email protected]>
@AlbertoMolinaIoBuilders @Axel-IoBuilders
factory updated
3b10c82 
Signed-off-by: Alberto Molina <[email protected]>
@AlbertoMolinaIoBuilders @Axel-IoBuilders
beneficiaries time travel
59fef8f 
Signed-off-by: Alberto Molina <[email protected]>
@Axel-IoBuilders
feat: scripts updated
3058bbf 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
feat: updateBeneficiaryData added
1ad3a9f 
Signed-off-by: Axel Loupias <[email protected]>
@AlbertoMolinaIoBuilders @Axel-IoBuilders
beneficiaries tests added
aada6d0 
Signed-off-by: Alberto Molina <[email protected]>
@Axel-IoBuilders
refactor: beneficiaries added to createbond in sdk
a26c4dc 
Signed-off-by: Axel Loupias <[email protected]>
@luigi-io @Axel-IoBuilders
refactor: previousData is not needed
62a1af7 
Signed-off-by: Luigi Navarro <[email protected]>
@Axel-IoBuilders
feat: add beneficiaries management to bond commands and adapters
d581876 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
feat: add beneficiaries SDK
eef71bb 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: rebase with develop
4edd9a5 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
feat: add beneficiaries query SDK
4b878a0 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: validation service isBeneficiary
0ae85d2 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: add optional field and fix service in command
95d4060 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: add validation createBond
4a9e27d 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: command createBondRequestCommand
2787786 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: beneficiaryData transaction adapters
e7f8153 
Signed-off-by: Axel Loupias <[email protected]>
@ManuIOB @Axel-IoBuilders
feat: web implementation
574e70a 
Signed-off-by: Manu Fernández <[email protected]>
@jaime-iobermudez @Axel-IoBuilders
fix: beneficiaryData hedera adapter
5bf8681 
Signed-off-by: jaime-iobermudez <[email protected]>
@Axel-IoBuilders
fix: adapters
a8a701f 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: request add beneficiary
084fca4 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders
fix: updateAddBeneficiaryData
e081fa4 
Signed-off-by: Axel Loupias <[email protected]>
@ManuIOB @Axel-IoBuilders
fix: hex validation
fcb5075 
Signed-off-by: Manu Fernández <[email protected]>
@Axel-IoBuilders
fix: comments pr
3765ac7 
Signed-off-by: Axel Loupias <[email protected]>
@ManuIOB @Axel-IoBuilders
fix: tests
dc7c59c 
Signed-off-by: Manu Fernández <[email protected]>
@ManuIOB @Axel-IoBuilders
fix: remove comments and 0x format
e11ca86 
Signed-off-by: Manu Fernández <[email protected]>
@jaime-iobermudez @Axel-IoBuilders
fix: apply roles hedera adapter
f8b2265 
Signed-off-by: jaime-iobermudez <[email protected]>
@Axel-IoBuilders Axel-IoBuilders force-pushed the bond-beneficiaries branch 3 times, most recently from 2f4aff7 to a70e44d Compare September 16, 2025 10:03
@Axel-IoBuilders Axel-IoBuilders changed the title feat: add bond beneficiaries #2 feat: add bond beneficiaries Sep 16, 2025
@Axel-IoBuilders
fix: sdk and contracts tests
f30a0fb 
Signed-off-by: Axel Loupias <[email protected]>
@Axel-IoBuilders Axel-IoBuilders marked this pull request as ready for review September 16, 2025 11:09
@Axel-IoBuilders Axel-IoBuilders requested review from a team as code owners September 16, 2025 11:09
@Axel-IoBuilders Axel-IoBuilders merged commit ff4e8a2 into develop Sep 16, 2025
11 checks passed
@Axel-IoBuilders Axel-IoBuilders deleted the bond-beneficiaries branch September 16, 2025 11:09
Axel-IoBuilders added a commit that referenced this pull request Sep 16, 2025
@Axel-IoBuilders @AlbertoMolinaIoBuilders
@luigi-io @ManuIOB @jaime-iobermudez
feat: add bond beneficiaries (#660)
16c8659 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel-IoBuilders <--global>
Axel-IoBuilders added a commit that referenced this pull request Sep 16, 2025
@Axel-IoBuilders @AlbertoMolinaIoBuilders
@luigi-io @ManuIOB @jaime-iobermudez
feat: add bond beneficiaries (#660)
8c532ff 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>
themariofrancia pushed a commit that referenced this pull request Sep 25, 2025
@Axel-IoBuilders @AlbertoMolinaIoBuilders
@luigi-io @ManuIOB @jaime-iobermudez @themariofrancia
feat: add bond beneficiaries (#660)
0890a6e 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
themariofrancia pushed a commit that referenced this pull request Dec 9, 2025
@Axel-IoBuilders @AlbertoMolinaIoBuilders
@luigi-io @ManuIOB @jaime-iobermudez
feat: add bond beneficiaries (#660)
1758d58 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>
themariofrancia pushed a commit that referenced this pull request Dec 10, 2025
@Axel-IoBuilders @AlbertoMolinaIoBuilders
@luigi-io @ManuIOB @jaime-iobermudez
feat: add bond beneficiaries (#660)
78b193c 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>
themariofrancia pushed a commit that referenced this pull request Dec 10, 2025
@Axel-IoBuilders
feat: add bond beneficiaries (#660)
1ffeb05 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaime-iobermudez jaime-iobermudez jaime-iobermudez approved these changes

@Neurone Neurone Awaiting requested review from Neurone Neurone was automatically assigned from hashgraph/developer-advocates

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Axel-IoBuilders @hedera-eng-infrastructure @jaime-iobermudez @AlbertoMolinaIoBuilders @luigi-io @ManuIOB